AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r406472565
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -206,6 +214,23 @@ void retriggerSubpartitionRequest(int subpartitionIndex)
throws IOException {
return Optional.of(new BufferAndAvailability(next,
moreAvailable, getSenderBacklog()));
}
+ @Override
+ public List<Buffer> getInflightBuffers(long checkpointId) throws
IOException {
+ synchronized (receivedBuffers) {
+ final List<Buffer> inflightBuffers = new
ArrayList<>(receivedBuffers.size());
+ for (Buffer buffer : receivedBuffers) {
+ if (!buffer.isBuffer() &&
parseCheckpointBarrierOrNull(buffer) != null) {
+ break;
+ }
+ inflightBuffers.add(buffer.retainBuffer());
+ }
+
+ triggeredCheckpointId = checkpointId;
Review comment:
Added the `checkState` and I agree that the naming is not ideal.
I renamed `getInflightBuffers` to `requestInflightBuffers` (as suggested),
and used `lastRequestedCheckpointId` instead of `triggeredCheckpointId` to
highlight its usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
