wangyang0918 commented on a change in pull request #11708: [FLINK-15816][k8s] 
Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407437003
 
 

 ##########
 File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java
 ##########
 @@ -66,6 +67,7 @@ public String getClusterId(Configuration configuration) {
        }
 
        private String generateClusterId() {
 
 Review comment:
   The default schema of UUID is `e4225fc5-e4a1-4a81-b9b5-0b48baeea7a1`. Maybe 
it already meets our requirements. Also leaving the dash `-` could help to keep 
the name in a human readable pattern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to