wangyang0918 commented on a change in pull request #11708: [FLINK-15816][k8s] 
Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407438510
 
 

 ##########
 File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
 ##########
 @@ -133,8 +133,8 @@
                key("kubernetes.cluster-id")
                .stringType()
                .noDefaultValue()
-               .withDescription("The cluster id used for identifying the 
unique flink cluster. If it's not set, " +
-                       "the client will generate a random UUID name.");
+               .withDescription("The cluster-id, which should be no more than 
45 characters, is used for identifying " +
 
 Review comment:
   I am not sure why do we only allow `45` characters here? Do you mean to 
leave some possible prefix/suffix for the future?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to