xintongsong commented on a change in pull request #11615: [FLINK-16605] Add max
limitation to the total number of slots
URL: https://github.com/apache/flink/pull/11615#discussion_r407373680
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManagerFactory.java
##########
@@ -48,14 +49,18 @@
ClusterInformation clusterInformation,
@Nullable String webInterfaceUrl,
ResourceManagerMetricGroup resourceManagerMetricGroup)
throws Exception {
+ // The max slot limit should not take effect for standalone
cluster, we override the configure in case user
+ // sets this value by mistake.
+ Configuration copiedConfig = new Configuration(configuration);
+ copiedConfig.setInteger(ResourceManagerOptions.MAX_SLOT_NUM,
Integer.MAX_VALUE);
Review comment:
nit: I would suggest to have a separated util method
`getConfigurationForStandaloneResourceManager` for the configuration
overwriting, to encapsulate the details from `StandaloneResourceManagerFactory`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
