xintongsong commented on a change in pull request #11615: [FLINK-16605] Add max
limitation to the total number of slots
URL: https://github.com/apache/flink/pull/11615#discussion_r407369321
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
##########
@@ -76,6 +77,14 @@
.withDeprecatedKeys("yarn.heap-cutoff-min")
.withDescription("Minimum amount of heap memory to remove in
Job Master containers, as a safety margin.");
+ @Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING)
+ public static final ConfigOption<Integer> MAX_SLOT_NUM = ConfigOptions
+ .key("slotmanager.number-of-slots.max")
+ .intType()
+ .defaultValue(Integer.MAX_VALUE)
+ .withDescription("Defines the max limitation of the total
number of slots. This configuration is meant for batch " +
+ "scenarios. For streaming job, it might cause problems.
For standalone cluster, this configuration will not take effect.");
Review comment:
I would suggest the following:
```
Defines the maximum number of slots that the Flink cluster allocates.
This configuration option is meant for limiting the memory consumption for
batch workloads.
It is not recommended to configure this option for streaming workloads,
which may fail if there are not enough slots.
Note that this configuration option does not take effect for standalone
clusters, where how many slots are allocated is not controlled by Flink.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
