KurtYoung commented on a change in pull request #11674: [FLINK-16887][table-planner-blink] Refactor retraction rules to support inferring ChangelogMode URL: https://github.com/apache/flink/pull/11674#discussion_r407349672
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/trait/UpdateKind.java ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.trait; + +/** + * Lists all kinds of {@link ModifyKind#UPDATE} operation. + */ +public enum UpdateKind { + + /** + * No update operation. + */ + NO_UPDATE, + + /** + * This kind indicates that operators should emit update changes just as a row of + * {@code RowKind#UPDATE_AFTER}. + */ + ONLY_UPDATE_AFTER, + + /** + * This kind indicates that operators should emit update changes in the way that + * a row of {@code RowKind#UPDATE_BEFORE} and a row of {@code RowKind#UPDATE_AFTER} together. + */ + BEFORE_AND_AFTER; + + /** + * Return a new UpdateKind which merges this UpdateKind and the other UpdateKind. + */ + public UpdateKind merge(UpdateKind that) { Review comment: It's hard to imagine & understand why this class support `merge`, what should be the expected behavior? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
