wuchong commented on a change in pull request #11674:
[FLINK-16887][table-planner-blink] Refactor retraction rules to support
inferring ChangelogMode
URL: https://github.com/apache/flink/pull/11674#discussion_r407332545
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/join/JoinTest.xml
##########
@@ -313,17 +313,17 @@ LogicalProject(a1=[$1], b1=[$3])
</Resource>
<Resource name="planAfter">
<![CDATA[
-Join(joinType=[InnerJoin], where=[=(a1, b1)], select=[a1, b1],
leftInputSpec=[JoinKeyContainsUniqueKey],
rightInputSpec=[JoinKeyContainsUniqueKey], updateAsRetraction=[false],
accMode=[Acc])
-:- Exchange(distribution=[hash[a1]], updateAsRetraction=[false], accMode=[Acc])
-: +- GroupAggregate(groupBy=[a1], select=[a1], updateAsRetraction=[false],
accMode=[Acc])
-: +- Exchange(distribution=[hash[a1]], updateAsRetraction=[true],
accMode=[Acc])
-: +- Calc(select=[a1, a2], updateAsRetraction=[true], accMode=[Acc])
-: +- TableSourceScan(table=[[default_catalog, default_database, A,
source: [TestTableSource(a1, a2, a3)]]], fields=[a1, a2, a3],
updateAsRetraction=[true], accMode=[Acc])
-+- Exchange(distribution=[hash[b1]], updateAsRetraction=[false], accMode=[Acc])
- +- GroupAggregate(groupBy=[b1], select=[b1], updateAsRetraction=[false],
accMode=[Acc])
- +- Exchange(distribution=[hash[b1]], updateAsRetraction=[true],
accMode=[Acc])
- +- Calc(select=[b1, b2], updateAsRetraction=[true], accMode=[Acc])
- +- TableSourceScan(table=[[default_catalog, default_database, B,
source: [TestTableSource(b1, b2, b3)]]], fields=[b1, b2, b3],
updateAsRetraction=[true], accMode=[Acc])
+Join(joinType=[InnerJoin], where=[=(a1, b1)], select=[a1, b1],
leftInputSpec=[JoinKeyContainsUniqueKey],
rightInputSpec=[JoinKeyContainsUniqueKey], changelogMode=[I,UA,D])
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
