zhengcanbin opened a new pull request #11708: [FLINK-15816][k8s] Limit the 
value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708
 
 
   ## What is the purpose of the change
   
   Among all kinds of k8s components that we already introduced in Flink, the 
Deployment and the Service have length limitation on its name and they must be 
no more than 63 characters; therefore, this PR adds precheck on the config 
option of `kubernetes.cluster-id` to ensure that its value is no more than 45 
characters.
   
   
   ## Brief change log
   
     - Add length check for the config option of `kubernetes.cluster-id`.
     - Remove `-` from the auto-generated UUID string and get prefix string(45 
characters) of the final generaged cluster-id in 
`KubernetesClusterClientFactory#generateClusterId`.
   
   
   ## Verifying this change
   
   This change added unit tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to