hequn8128 commented on a change in pull request #11656: [FLINK-16983][python]
Support RowType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11656#discussion_r406051576
##########
File path:
flink-python/src/test/java/org/apache/flink/table/runtime/arrow/RowArrowReaderWriterTest.java
##########
@@ -118,18 +127,20 @@ public static void init() {
SqlDateTimeUtils.internalToTime(3600000),
SqlDateTimeUtils.internalToTime(3600000),
SqlDateTimeUtils.internalToTime(3600000),
SqlDateTimeUtils.internalToTime(3600000),
new Timestamp(3600000), new Timestamp(3600000), new
Timestamp(3600000), new Timestamp(3600000),
new Timestamp(3600000), new Timestamp(3600000), new
Timestamp(3600000), new Timestamp(3600000),
- new String[] {null, null, null});
+ new String[] {null, null, null},
+ Row.of(1, "hello", new String[] {null, null, null}, new
Timestamp(3600000), Row.of(1, "hello")));
Row row2 = Row.of(null, (short) 2, 3, 4L, false, 1.0f, 1.0,
"中文", "中文".getBytes(), new BigDecimal(1), SqlDateTimeUtils.internalToDate(100),
SqlDateTimeUtils.internalToTime(3600000),
SqlDateTimeUtils.internalToTime(3600000),
SqlDateTimeUtils.internalToTime(3600000),
SqlDateTimeUtils.internalToTime(3600000),
new Timestamp(3600000), new Timestamp(3600000), new
Timestamp(3600000), new Timestamp(3600000),
new Timestamp(3600000), new Timestamp(3600000), new
Timestamp(3600000), new Timestamp(3600000),
- new String[] {"hello", "中文", null});
+ new String[] {"hello", "中文", null},
+ Row.of(1, "hello", new String[] {"hello", "中文", null},
new Timestamp(3600000), Row.of(1, "hello")));
Row row3 = Row.of((byte) 1, null, 3, 4L, true, 1.0f, 1.0,
"hello", "hello".getBytes(), new BigDecimal(1),
SqlDateTimeUtils.internalToDate(100),
SqlDateTimeUtils.internalToTime(3600000),
SqlDateTimeUtils.internalToTime(3600000),
SqlDateTimeUtils.internalToTime(3600000),
SqlDateTimeUtils.internalToTime(3600000),
new Timestamp(3600000), new Timestamp(3600000), new
Timestamp(3600000), new Timestamp(3600000),
new Timestamp(3600000), new Timestamp(3600000), new
Timestamp(3600000), new Timestamp(3600000),
- null);
- Row row4 = Row.of(null, null, null, null, null, null, null,
null, null, null, null, null, null, null, null, null, null, null, null, null,
null, null, null, null);
+ null, null);
+ Row row4 = Row.of(null, null, null, null, null, null, null,
null, null, null, null, null, null, null, null, null, null, null, null, null,
null, null, null, null, null);
Review comment:
new Row(n)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
