hequn8128 commented on a change in pull request #11656: [FLINK-16983][python] 
Support RowType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11656#discussion_r406036867
 
 

 ##########
 File path: flink-python/pyflink/table/tests/test_pandas_udf.py
 ##########
 @@ -165,6 +165,12 @@ def nested_array_func(nested_array_param):
                 'nested_array_param of wrong type %s !' % 
type(nested_array_param[0])
             return pd.Series(nested_array_param[0])
 
+        def row_func(row_param):
+            assert isinstance(row_param, pd.Series)
+            assert isinstance(row_param[0], dict), \
 
 Review comment:
   It is strange to return `dict` type while the input type is `Row`. And there 
is no order guarantee for the field in dict which maybe not consistent with the 
semantic of Row.
   Is it possible to convert the pd.Series into a Series contains Row? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to