zhijiangW commented on a change in pull request #11515: [FLINK-16744][task]
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r403482247
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -651,7 +651,7 @@ boolean isSerializingTimestamps() {
* Gets the name of the task, in the form "taskname (2/5)".
* @return The name of the task.
*/
- public String getName() {
+ public final String getName() {
Review comment:
Yes, i agree with your consideration for `inconsistency between values used
in constructor with ones in getters`.
Regarding the `AbstractInvokable` and `StreamTask`, you misunderstood my
previous comment. I mean that there might still have other methods inside
parent `AbstractInvokable` and `StreamTask`, which should not be overridden by
subclasses, so it should also be defined as final as you already did in this
PR. Now we only consider the requirements from
`SubtaskCheckpointCoordinatorImpl` to handle the related methods. But from a
more general motivation, we might need to go through all the necessary methods
to limit them as final to make this story complete. But it is up to you whether
to touch more things in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
