wuchong commented on a change in pull request #11538: [FLINK-16813][jdbc]
JDBCInputFormat doesn't correctly map Short
URL: https://github.com/apache/flink/pull/11538#discussion_r401427599
##########
File path:
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JdbcTestFixture.java
##########
@@ -96,12 +99,12 @@ public String toString() {
}
}
- static final RowTypeInfo ROW_TYPE_INFO = new RowTypeInfo(
+ static final RowType ROW_TYPE = (RowType) fromLegacyInfoToDataType(new
RowTypeInfo(
Review comment:
If we decide to use RowType, please use `DataTypes` to construct a
`RowType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
