wuchong commented on a change in pull request #11538: [FLINK-16813][jdbc]
JDBCInputFormat doesn't correctly map Short
URL: https://github.com/apache/flink/pull/11538#discussion_r401426619
##########
File path:
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/catalog/PostgresCatalogTestBase.java
##########
@@ -138,78 +146,122 @@ public static TestTable getSimpleTable() {
TableSchema.builder()
.field("id", DataTypes.INT())
.build(),
- "id integer"
+ "id integer",
+ "1"
);
}
- public static TestTable getDataTypesTable() {
+ // TODO: add back timestamptz once blink planner supports timestamp
with timezone
+ public static TestTable getPrimitiveTable() {
return new TestTable(
TableSchema.builder()
.field("int", DataTypes.INT())
- .field("int_arr",
DataTypes.ARRAY(DataTypes.INT()))
.field("bytea", DataTypes.BYTES())
- .field("bytea_arr",
DataTypes.ARRAY(DataTypes.BYTES()))
.field("short", DataTypes.SMALLINT())
- .field("short_arr",
DataTypes.ARRAY(DataTypes.SMALLINT()))
.field("long", DataTypes.BIGINT())
- .field("long_arr",
DataTypes.ARRAY(DataTypes.BIGINT()))
.field("real", DataTypes.FLOAT())
- .field("real_arr",
DataTypes.ARRAY(DataTypes.FLOAT()))
.field("double_precision", DataTypes.DOUBLE())
- .field("double_precision_arr",
DataTypes.ARRAY(DataTypes.DOUBLE()))
.field("numeric", DataTypes.DECIMAL(10, 5))
- .field("numeric_arr",
DataTypes.ARRAY(DataTypes.DECIMAL(10, 5)))
.field("boolean", DataTypes.BOOLEAN())
- .field("boolean_arr",
DataTypes.ARRAY(DataTypes.BOOLEAN()))
.field("text", DataTypes.STRING())
- .field("text_arr",
DataTypes.ARRAY(DataTypes.STRING()))
.field("char", DataTypes.CHAR(1))
- .field("char_arr",
DataTypes.ARRAY(DataTypes.CHAR(1)))
.field("character", DataTypes.CHAR(3))
- .field("character_arr",
DataTypes.ARRAY(DataTypes.CHAR(3)))
.field("character_varying",
DataTypes.VARCHAR(20))
- .field("character_varying_arr",
DataTypes.ARRAY(DataTypes.VARCHAR(20)))
.field("timestamp", DataTypes.TIMESTAMP(5))
- .field("timestamp_arr",
DataTypes.ARRAY(DataTypes.TIMESTAMP(5)))
- .field("timestamptz",
DataTypes.TIMESTAMP_WITH_LOCAL_TIME_ZONE(4))
- .field("timestamptz_arr",
DataTypes.ARRAY(DataTypes.TIMESTAMP_WITH_LOCAL_TIME_ZONE(4)))
+// .field("timestamptz",
DataTypes.TIMESTAMP_WITH_LOCAL_TIME_ZONE(4))
Review comment:
Blink planner does support TIMESTAMP WITH LOCAL TIME ZONE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
