rkhachatryan commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r400371451
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java
##########
@@ -212,46 +218,66 @@ protected MasterState
deserializeMasterState(DataInputStream dis) throws IOExcep
//
------------------------------------------------------------------------
protected void serializeSubtaskState(OperatorSubtaskState subtaskState,
DataOutputStream dos) throws IOException {
- final OperatorStateHandle managedOperatorState =
extractSingleton(subtaskState.getManagedOperatorState());
- if (managedOperatorState != null) {
+ serializeSingleton(subtaskState.getManagedOperatorState(), dos,
MetadataV2V3SerializerBase::serializeOperatorStateHandle);
+ serializeSingleton(subtaskState.getRawOperatorState(), dos,
MetadataV2V3SerializerBase::serializeOperatorStateHandle);
+ serializeKeyedStateCol(subtaskState.getManagedKeyedState(),
dos);
+ serializeKeyedStateCol(subtaskState.getRawKeyedState(), dos);
+ serializeCollection(subtaskState.getInputChannelState(), dos,
this::serializeInputChannelStateHandle);
+ serializeCollection(subtaskState.getResultSubpartitionState(),
dos, this::serializeResultSubpartitionStateHandle);
Review comment:
You are right. I'll move this code to V3 subclass to keep V2 format intact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
