rkhachatryan commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r398870586
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV3Serializer.java
##########
@@ -115,4 +120,31 @@ protected OperatorState
deserializeOperatorState(DataInputStream dis) throws IOE
return operatorState;
}
+
+ @VisibleForTesting
+ @Override
+ public void
serializeResultSubpartitionStateHandle(ResultSubpartitionStateHandle handle,
DataOutputStream dos) throws IOException {
+ channelStateHandleSerializer.serialize(handle, dos);
+ }
+
+ @VisibleForTesting
+ @Override
+ public ResultSubpartitionStateHandle
deserializeResultSubpartitionStateHandle(DataInputStream dis) throws
IOException {
+ final boolean hasResultSubpartitionStateHandle = dis.readInt()
!= 0;
Review comment:
Just to clarify:
- V3 serializer was added in this release (1.11); initially, it was added
for FLIP-27 operator coordinators state
- the versioning mechanism was added several years ago
So any test that reads a snapshot from file covers this because these files
were written with serializer V2 or older. There are a lot of such tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
