AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic 
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399253795
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
 ##########
 @@ -93,6 +97,12 @@ public static CheckpointedInputGate 
createCheckpointedInputGate(
                        toNotifyOnCheckpoint);
                registerCheckpointMetrics(taskIOMetricGroup, barrierHandler);
 
+               if (config.isUnalignedCheckpointsEnabled()) {
 
 Review comment:
   Hm, I'm not convinced that it would make the code more compact or easier to 
maintain since I currently don't see it being used in more than these two 
places. Would N-ary input operators affect that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to