pnowojski commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r399252660
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -54,6 +54,10 @@ public static CheckpointedInputGate
createCheckpointedInputGate(
config, inputGate.getNumberOfInputChannels(), taskName,
toNotifyOnCheckpoint);
registerCheckpointMetrics(taskIOMetricGroup, barrierHandler);
+ if (config.isUnalignedCheckpointsEnabled()) {
+
inputGate.registerBufferReceivedListener(barrierHandler);
+ }
Review comment:
nit: We could always register the listener, but aligned handler could be
just ignoring the calls. It would make more OO design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
