bowenli86 commented on a change in pull request #11538: [FLINK-16813][jdbc]
JDBCInputFormat doesn't correctly map Short
URL: https://github.com/apache/flink/pull/11538#discussion_r399028768
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialect.java
##########
@@ -139,4 +145,23 @@ default String getSelectFromStatement(String tableName,
String[] selectFields, S
return "SELECT " + selectExpressions + " FROM " +
quoteIdentifier(tableName) +
(conditionFields.length > 0 ? " WHERE " + fieldExpressions : "");
}
+
+ /**
+ * Set {@link Row} with data retrieved from {@link ResultSet} according
to {@link RowType}.
+ *
+ * @param resultSet ResultSet from JDBC
+ * @param rowType RowType of the row
+ * @param reuse The row to set
+ */
+ default void setRow(ResultSet resultSet, RowType rowType, Row reuse)
throws SQLException {
Review comment:
I've renamed that JIRA, I think a new API in JDBCDialect would be enough for
the job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
