wuchong commented on a change in pull request #11538: [FLINK-16813][jdbc]  
JDBCInputFormat doesn't correctly map Short
URL: https://github.com/apache/flink/pull/11538#discussion_r398997030
 
 

 ##########
 File path: 
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
 ##########
 @@ -127,7 +134,7 @@ public JDBCInputFormat() {
 
        @Override
        public RowTypeInfo getProducedType() {
-               return rowTypeInfo;
+               return (RowTypeInfo) 
fromDataTypeToLegacyInfo(fromLogicalToDataType(rowType));
 
 Review comment:
   This will lost original conversion class. For example, JDBC are using 
`java.sql.Timstamp` as produced type, however, it will use `LocalDateTime` as 
produced type after this change. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to