pnowojski commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r396987261
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/InputChannelStateHandle.java
##########
@@ -16,11 +15,23 @@
* limitations under the License.
*/
+package org.apache.flink.runtime.state;
+
+import org.apache.flink.annotation.Internal;
import org.apache.flink.runtime.checkpoint.channel.InputChannelInfo;
+import java.util.List;
+
/**
* {@link StateObject Handle} to an {@link
org.apache.flink.runtime.io.network.partition.consumer.InputChannel
InputChannel} state.
*/
-public interface InputChannelStateHandle extends StateObject {
- InputChannelInfo getInputChannelInfo();
+@Internal
+// not final for mockito
+public /*final*/ class InputChannelStateHandle extends
AbstractChannelStateHandle<InputChannelInfo> {
Review comment:
I would drop
```
// not final for mockito
/*final*/
```
comments. They can do more harm than good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
