pnowojski commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r396993972
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV3Serializer.java
##########
@@ -115,4 +120,31 @@ protected OperatorState
deserializeOperatorState(DataInputStream dis) throws IOE
return operatorState;
}
+
+ @VisibleForTesting
+ @Override
+ public void
serializeResultSubpartitionStateHandle(ResultSubpartitionStateHandle handle,
DataOutputStream dos) throws IOException {
+ channelStateHandleSerializer.serialize(handle, dos);
+ }
+
+ @VisibleForTesting
+ @Override
+ public ResultSubpartitionStateHandle
deserializeResultSubpartitionStateHandle(DataInputStream dis) throws
IOException {
+ final boolean hasResultSubpartitionStateHandle = dis.readInt()
!= 0;
Review comment:
are you sure that `dis.readInt() != 0` is good enough check to maintain
backward compatibility?
Do we have test coverage for that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
