[
https://issues.apache.org/jira/browse/FLINK-16715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064658#comment-17064658
]
Kostas Kloudas commented on FLINK-16715:
----------------------------------------
[~xintongsong] I see your point. In general the whole {{YarnClusterDescriptor}}
could use some refactoring (e.g. the {{startAppMaster()}} has ~400 lines of
code). I do not have strong feelings about using the one or the other
({{configuration}} or {{flinkConfiguration}) and maybe using the class member
makes it clearer that these changes will be visible to all methods in the
class.
> Always use the configuration argument in YarnClusterDescriptor#startAppMaster
> to make it more self-contained
> ------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-16715
> URL: https://issues.apache.org/jira/browse/FLINK-16715
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / YARN
> Reporter: Canbin Zheng
> Priority: Trivial
> Fix For: 1.11.0
>
>
> In the YarnClusterDescriptor#{{startAppMaster()}} we are using some time the
> {{configuration}} argument to the method to get/set config options, and
> sometimes the {{flinkConfiguration}} which is a class member. This ticket
> proposes to always use the {{configuration}} argument to make the method more
> self-contained.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
