[
https://issues.apache.org/jira/browse/FLINK-16715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064634#comment-17064634
]
Xintong Song commented on FLINK-16715:
--------------------------------------
I tend to think this differently.
Instead of always using {{configuration}} argument, I would suggest to always
use the class field {{flinkConfiguration}}, for the following reasons.
* As a private non-static method, we don't really need {{startAppMaster}} to be
self-contained.
* Even we change it to always use the argument, it does guarantee that in
future, because the class field is visible to the method anyway. On the other
hand, if we change it to always use the class filed, we can remove the method
argument to make sure there is only one configuration visible to the method.
* It helps reducing the number of arguments needed for the {{startAppMaster}}
method.
Actually, I think we should do the same thing for {{yarnClient}}, which is also
a class field.
> Always use the configuration argument in YarnClusterDescriptor#startAppMaster
> to make it more self-contained
> ------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-16715
> URL: https://issues.apache.org/jira/browse/FLINK-16715
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / YARN
> Reporter: Canbin Zheng
> Priority: Trivial
> Fix For: 1.11.0
>
>
> In the YarnClusterDescriptor#{{startAppMaster()}} we are using some time the
> {{configuration}} argument to the method to get/set config options, and
> sometimes the {{flinkConfiguration}} which is a class member. This ticket
> proposes to always use the {{configuration}} argument to make the method more
> self-contained.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
