danny0405 commented on issue #11340: [Flink 14338] Upgrade Calcite version to 
1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#issuecomment-599870394
 
 
   > Thanks for update @danny0405, LGTM
   > 
   > I do not check the plans which are out of order
   
   Thanks, i re-checked the out-of-order XML files:
   
   +batch/sql/agg/WindowAggregateTest
   +batch/sql/LimitTest
   +stream/sql/agg/IncrementalAggregateTest
   +rules/logical/SplitAggregateRuleTest
   +stream/sql/DeduplicateTest
   
   A few plans of the WindowAggregateTest generates LocalHashWindowAggregate 
and the plan is better, almost all the others are with same plan(just an order 
change), some of the order change  is because we forgot to remove the plans in 
the xml file when removing the tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to