danny0405 commented on issue #11340: [Flink 14338] Upgrade Calcite version to 
1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#issuecomment-599339761
 
 
   > > > Thanks @danny0405 so much for this huge work, I left some comments. I 
notice there are a lot of alias name in the plans are dropped, does calcite not 
care about alias changes?
   > > 
   > > 
   > > Yes, the alias actually does not affect the semantics of the plan, we 
can reuse more sub-graph if we ignore that, this is the background CALCITE-3713 
fired.
   > 
   > I agree with you that the alias does not affect the semantics, but the 
users will confuse in SQL client if the alias of sink column is dropped.
   
   Yes, column name representation for SQL client is another topic, for example 
`select a+b from t1` will output the column name as `$Expr0` instead of "a + 
b"(i.e. the MySQL CLI), i have flred an issue to track this problem: 
https://issues.apache.org/jira/browse/FLINK-16609, i would solve this issue in 
1.11.0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to