KurtYoung commented on a change in pull request #11334: 
[FLINK-16464][sql-client]result-mode tableau may shift when content contains 
Chinese String in SQL CLI
URL: https://github.com/apache/flink/pull/11334#discussion_r390079359
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliUtils.java
 ##########
 @@ -111,4 +113,33 @@ public static void 
normalizeColumn(AttributedStringBuilder sb, String col, int m
                }
                return typesAsString;
        }
+
+       public static int getStringWidth(String str) {
 
 Review comment:
   please add unit tests for both newly added methods. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to