[GitHub] [flink] leonardBang commented on a change in pull request #11334: [FLINK-16464][sql-client]result-mode tableau may shift when content contains Chinese String in SQL CLI

[GitBox]

leonardBang commented on a change in pull request #11334: 
[FLINK-16464][sql-client]result-mode tableau may shift when content contains 
Chinese String in SQL CLI
URL: https://github.com/apache/flink/pull/11334#discussion_r389232993
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java
 ##########
 @@ -167,8 +177,9 @@ public void testBatchResult() {
                                "|   false | -2147483648 |  9223372036854775807 
|                     (NULL) |    12345.06789 |    2020-03-01 18:39:14.123 |\n" 
+
                                "|    true |         100 | -9223372036854775808 
|                 abcdefg111 |         (NULL) | 2020-03-01 18:39:14.123456 |\n" 
+
                                "|  (NULL) |          -1 |                   -1 
| abcdefghijklmnopqrstuvwxyz |   -12345.06789 |                     (NULL) |\n" 
+
+                               "|  (NULL) |          -1 |                   -1 
|         这是一段中文 |   -12345.06789 |      2020-03-04 18:39:14.0 |\n"     +
 
 Review comment:
   Using GBK works well with Chinese, 
   
![image](https://user-images.githubusercontent.com/5163645/76138195-74360880-6080-11ea-96ca-e1bc90c1dfdb.png)
   
   
   my concern is other language like Japanese/Korean have same problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services