JingsongLi commented on a change in pull request #10922:
[FLINK-11899][parquet][table-runtime] Introduce ParquetColumnarRowSplitReader
URL: https://github.com/apache/flink/pull/10922#discussion_r386204323
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/vector/heap/AbstractHeapVector.java
##########
@@ -18,14 +18,25 @@
package org.apache.flink.table.dataformat.vector.heap;
-import org.apache.flink.table.dataformat.vector.AbstractColumnVector;
+import org.apache.flink.core.memory.MemoryUtils;
+import
org.apache.flink.table.dataformat.vector.writable.AbstractWritableVector;
+import java.nio.ByteOrder;
import java.util.Arrays;
/**
* Heap vector that nullable shared structure.
*/
-public abstract class AbstractHeapVector extends AbstractColumnVector {
+public abstract class AbstractHeapVector extends AbstractWritableVector {
+
+ public static final boolean LITTLE_ENDIAN = ByteOrder.nativeOrder() ==
ByteOrder.LITTLE_ENDIAN;
+
+ public static final sun.misc.Unsafe UNSAFE = MemoryUtils.UNSAFE;
+ public static final int BYTE_ARRAY_OFFSET =
UNSAFE.arrayBaseOffset(byte[].class);
Review comment:
Use `arrayBaseOffset` is more safe for cross platform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
