JingsongLi commented on a change in pull request #10922:
[FLINK-11899][parquet][table-runtime] Introduce ParquetColumnarRowSplitReader
URL: https://github.com/apache/flink/pull/10922#discussion_r386203967
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/vector/heap/AbstractHeapVector.java
##########
@@ -56,11 +67,31 @@ public void reset() {
noNulls = true;
}
+ @Override
public void setNullAt(int i) {
+ if (i >= isNull.length) {
+ throw new RuntimeException();
+ }
isNull[i] = true;
noNulls = false;
}
+ @Override
+ public void setNulls(int i, int count) {
+ for (int j = 0; j < count; j++) {
+ isNull[i + j] = true;
Review comment:
No need to update `noNulls`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
