dianfu commented on a change in pull request #11118: [FLINK-16072][python] 
Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381725940
 
 

 ##########
 File path: flink-python/pyflink/fn_execution/coder_impl.py
 ##########
 @@ -24,57 +24,71 @@
 from pyflink.table import Row
 
 
+def generate_null_mask_search_table():
 
 Review comment:
   Make it a private method of FlattenRowCoderImpl? I think there is no need to 
expose it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to