dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask URL: https://github.com/apache/flink/pull/11118#discussion_r381188340
########## File path: flink-python/pyflink/fn_execution/coder_impl.py ########## @@ -25,56 +25,331 @@ class FlattenRowCoderImpl(StreamCoderImpl): + null_mask_search_table = ((False, False, False, False, False, False, False, False), Review comment: Could we generate this search table using one function? Besides, it would be great to add some comments on how to generate the search table. It will make it more readable and maintainable. What's your thought? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
