gaoyunhaii commented on a change in pull request #7368: [FLINK-10742][network] 
Let Netty use Flink's buffers directly in credit-based mode
URL: https://github.com/apache/flink/pull/7368#discussion_r376849678
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/BufferResponseAndNoDataBufferMessageParser.java
 ##########
 @@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.netty;
+
+import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
+
+/**
+ * The parser for both {@link NettyMessage.BufferResponse} and messages 
without data buffer.
+ */
+public class BufferResponseAndNoDataBufferMessageParser extends 
NoDataBufferMessageParser {
+
+    /** The allocator for the Flink buffer. */
+    private final NetworkBufferAllocator networkBufferAllocator;
+
+    BufferResponseAndNoDataBufferMessageParser(NetworkBufferAllocator 
networkBufferAllocator) {
+        this.networkBufferAllocator = networkBufferAllocator;
+    }
+
+    @Override
+    public int getMessageHeaderLength(int lengthWithoutFrameHeader, int msgId) 
{
+        if (msgId == NettyMessage.BufferResponse.ID) {
 
 Review comment:
   I think it should be hard to achieve to let the 
`ZeroCopyNettyMessageDecoder` to decide whether the `messageHeaderBuffer` has 
been fulfilled without knowing its size in advance: When receiving a new piece 
of data from the socket, if we do not known the size of the message header 
part, we could not decide which part should be copied into 
`messageHeaderBuffer`. 
   
   I also agree with that it is better to decide the `size` inside the 
messages. Thus currently I added a static `getMessageHeaderLength ` method to 
`ErrorResponse` and `BufferResponse` class and delegate the size acquisition to 
the specific messages, which is similar to the current pattern of `readFrom`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to