stevenzwu edited a comment on issue #11017: [FLINK-15907] [runtime] 
[configuration] expose getRawValue as protect…
URL: https://github.com/apache/flink/pull/11017#issuecomment-582724007
 
 
   Let me clarify what we are doing. We extends from `SessionClusterEntrypoint` 
and `TaskManagerRunner` to add integration with our ecosystem during startup. 
We are passing our extension of Configuration class (backed by Archaius) to 
`TaskManagerRunner`.  
   ```
   public TaskManagerRunner(Configuration configuration, ResourceID resourceId) 
   ```
   
   We do use the set/addAll APIs in a few places.  So 
`ReadableConfigToConfigurationAdapter` may not work for us.
   
   Also javadoc for `ReadableConfigToConfigurationAdapter` seems to indicate it 
is a bridge/stop-gap class. Do we want to make it public?
   ```
   It is used to bridge some of the old public interfaces that work with {@link 
Configuration} 
   even though they should actually work with {@link ReadableConfig}.
   ```
   
   Any other option to allow user to extend Configuration?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to