stevenzwu edited a comment on issue #11017: [FLINK-15907] [runtime] [configuration] expose getRawValue as protect… URL: https://github.com/apache/flink/pull/11017#issuecomment-582724007 Let me clarify what we are doing. We extends from `SessionClusterEntrypoint` and `TaskManagerRunner` to add integration with our ecosystem during startup. We are passing our extension of Configuration class (backed by Archaius) to `TaskManagerRunner`. if we pass in `ReadableConfigToConfigurationAdapter`, would it work for Flink? Does any Flink internal code call any set APIs on `Configuration`. ``` public TaskManagerRunner(Configuration configuration, ResourceID resourceId) ``` We do use the set/addAll APIs in a few places. But I think those are unnecessary. So `ReadableConfigToConfigurationAdapter` should be ok for us, as long as Flink internal code is ok. Also javadoc for `ReadableConfigToConfigurationAdapter` seems to indicate it is a bridge/stop-gap class. Do we want to make it public? ``` It is used to bridge some of the old public interfaces that work with {@link Configuration} even though they should actually work with {@link ReadableConfig}. ``` Right now, we talked about two options. 1) expose `getRawValue` as protected so that user can extend 2) make `ReadableConfigToConfigurationAdapter` public Any other option to allow user to extend Configuration?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
