[ 
https://issues.apache.org/jira/browse/FLINK-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020430#comment-15020430
 ] 

ASF GitHub Bot commented on FLINK-2956:
---------------------------------------

Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1349#discussion_r45545501
  
    --- Diff: 
flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/ExpressionsITCase.java
 ---
    @@ -98,11 +77,9 @@ public void testLogic() throws Exception {
                                "b && true, b && false, b || false, !b");
     
                DataSet<Row> ds = tableEnv.toDataSet(result, Row.class);
    -           ds.writeAsText(resultPath, FileSystem.WriteMode.OVERWRITE);
    -
    -           env.execute();
    -
    -           expected = "true,false,true,false";
    +           List<Row> results =ds.collect();
    --- End diff --
    
    Please add a space after `=`.


> Migrate integration tests for Table API
> ---------------------------------------
>
>                 Key: FLINK-2956
>                 URL: https://issues.apache.org/jira/browse/FLINK-2956
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Chengxiang Li
>            Priority: Minor
>
> Migrate integration tests of Table API from temp file to collect() as 
> described in umbrella jira..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to