[
https://issues.apache.org/jira/browse/FLINK-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004150#comment-15004150
]
ASF GitHub Bot commented on FLINK-2956:
---------------------------------------
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1349#issuecomment-156469184
Hi @gallenvara, I read your PR and have some comments.
First, since Flink 0.10, we dropped Java 6 support and can use omit types
if the types can be inferred. So could you remove type description in that
case? With removing, we can make codes more readable.
Second, to convert Scala sequence to Java list, using `JavaConverters` is
better than `JavaConversions`. For example:
```scala
import scala.collection.JavaConverters._
~skipped~
val result = ds.collect()
val expected = "~~~"
TestBaseUtils.compareResultAsText(result.asJava, expected)
```
After importing `scala.collection.JavaConverters._`, we can convert Scala
collection to Java collection with `asJava` method.
> Migrate integration tests for Table API
> ---------------------------------------
>
> Key: FLINK-2956
> URL: https://issues.apache.org/jira/browse/FLINK-2956
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Reporter: Chengxiang Li
> Priority: Minor
>
> Migrate integration tests of Table API from temp file to collect() as
> described in umbrella jira..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
