KarmaGYZ commented on a change in pull request #10746: [FLINK-15417] Remove the
docker volume or mount when starting Mesos e…
URL: https://github.com/apache/flink/pull/10746#discussion_r363723277
##########
File path: flink-end-to-end-tests/test-scripts/common_mesos_docker.sh
##########
@@ -52,11 +54,19 @@ function start_flink_cluster_with_mesos() {
set_config_key "jobmanager.rpc.address" "mesos-master"
set_config_key "rest.address" "mesos-master"
- docker exec -itd mesos-master bash -c "${FLINK_DIR}/bin/mesos-appmaster.sh
-Dmesos.master=mesos-master:5050"
+ docker cp ${FLINK_DIR} mesos-master:$MESOS_FLINK_DIR
+ docker cp ${END_TO_END_DIR}/test-scripts mesos-master:$MESOS_END_TO_END_DIR
+ docker cp ${END_TO_END_DIR}/test-scripts mesos-slave:$MESOS_END_TO_END_DIR
+
+ docker exec -itd mesos-master bash -c
"${MESOS_FLINK_DIR}/bin/mesos-appmaster.sh -Dmesos.master=mesos-master:5050"
wait_rest_endpoint_up "http://${NODENAME}:8081/taskmanagers"; "Dispatcher"
"\{\"taskmanagers\":\[.*\]\}"
return 0
}
+function copy_logs_from_container () {
Review comment:
If we copy logs to `${FLINK_DIR}/log`, the existing mechanism will help us
to clean up too. BTW, `post_test_validation` will check the error in it after
the test passed or failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
