KarmaGYZ commented on a change in pull request #10746: [FLINK-15417] Remove the
docker volume or mount when starting Mesos e…
URL: https://github.com/apache/flink/pull/10746#discussion_r366138517
##########
File path: flink-end-to-end-tests/test-scripts/common_mesos_docker.sh
##########
@@ -53,11 +55,22 @@ function start_flink_cluster_with_mesos() {
set_config_key "jobmanager.rpc.address" "mesos-master"
set_config_key "rest.address" "mesos-master"
- docker exec -itd mesos-master bash -c "${FLINK_DIR}/bin/mesos-appmaster.sh
-Dmesos.master=mesos-master:5050"
+ docker cp ${FLINK_DIR} mesos-master:$MESOS_FLINK_DIR
Review comment:
> all writes should go to a volume or bind mount
Regarding this concern, I think that the two approaches do not have
significant difference. Since We'll always write the log to the container's
storage. If you have a strong point here, I'm ok to bundle Flink and the test
data inside the image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
