sjwiesman commented on a change in pull request #10669:
[FLINK-15192][docs][table] Restructure "SQL" pages for better readability
URL: https://github.com/apache/flink/pull/10669#discussion_r361867385
##########
File path: docs/dev/table/sql/queries.md
##########
@@ -22,20 +22,18 @@ specific language governing permissions and limitations
under the License.
-->
-This is a complete list of Data Definition Language (DDL) and Data
Manipulation Language (DML) constructs supported in Flink.
* This will be replaced by the TOC
{:toc}
-## Query
-SQL queries are specified with the `sqlQuery()` method of the
`TableEnvironment`. The method returns the result of the SQL query as a
`Table`. A `Table` can be used in [subsequent SQL and Table API
queries](common.html#mixing-table-api-and-sql), be [converted into a DataSet or
DataStream](common.html#integration-with-datastream-and-dataset-api), or
[written to a TableSink](common.html#emit-a-table)). SQL and Table API queries
can be seamlessly mixed and are holistically optimized and translated into a
single program.
+SELECT queries are specified with the `sqlQuery()` method of the
`TableEnvironment`. The method returns the result of the SELECT query as a
`Table`. A `Table` can be used in [subsequent SQL and Table API queries]({{
site.baseurl }}/dev/table/common.html#mixing-table-api-and-sql), be [converted
into a DataSet or DataStream]({{ site.baseurl
}}/dev/table/common.html#integration-with-datastream-and-dataset-api), or
[written to a TableSink]({{ site.baseurl
}}/dev/table/common.html#emit-a-table)). SQL and Table API queries can be
seamlessly mixed and are holistically optimized and translated into a single
program.
-In order to access a table in a SQL query, it must be [registered in the
TableEnvironment](common.html#register-tables-in-the-catalog). A table can be
registered from a [TableSource](common.html#register-a-tablesource),
[Table](common.html#register-a-table), [CREATE TABLE statement](#create-table),
[DataStream, or
DataSet](common.html#register-a-datastream-or-dataset-as-table). Alternatively,
users can also [register catalogs in a TableEnvironment](catalogs.html) to
specify the location of the data sources.
+In order to access a table in a SQL query, it must be [registered in the
TableEnvironment]({{ site.baseurl
}}/dev/table/common.html#register-tables-in-the-catalog). A table can be
registered from a [TableSource]({{ site.baseurl
}}/dev/table/common.html#register-a-tablesource), [Table]({{ site.baseurl
}}/dev/table/common.html#register-a-table), [CREATE TABLE
statement](#create-table), [DataStream, or DataSet]({{ site.baseurl
}}/dev/table/common.html#register-a-datastream-or-dataset-as-table).
Alternatively, users can also [register catalogs in a TableEnvironment]({{
site.baseurl }}/dev/table/catalogs.html) to specify the location of the data
sources.
For convenience `Table.toString()` automatically registers the table under a
unique name in its `TableEnvironment` and returns the name. Hence, `Table`
objects can be directly inlined into SQL queries (by string concatenation) as
shown in the examples below.
**Note:** Flink's SQL support is not yet feature complete. Queries that
include unsupported SQL features cause a `TableException`. The supported
features of SQL on batch and streaming tables are listed in the following
sections.
Review comment:
I'm wondering if this first sentence is still necessary for if 1.10 is
feature complete enough to remove it. I don't want potential users to become
disuaded when we cover so much of the standard at this point.
```suggestion
**Note:** Queries that include unsupported SQL features cause a
`TableException`. The supported features of SQL on batch and streaming tables
are listed in the following sections.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
