tillrohrmann commented on a change in pull request #10466:
[FLINK-15110][metrics] Support variable exclusion
URL: https://github.com/apache/flink/pull/10466#discussion_r354933721
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
##########
@@ -71,7 +73,7 @@
protected final A parent;
/** The map containing all variables and their associated values,
lazily computed. */
- protected volatile Map<String, String> variables;
+ protected volatile Map<String, String>[] variables;
Review comment:
`variables`, `scopeComponents`, `scopeStrings` and `logicalScopeStrings`
seem to belong together. It might make sense to group them and to pull them out
of the `AbstractMetricGroup` in order to reduce the responsibilities of this
class. We should do this as a follow up, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
