tillrohrmann commented on a change in pull request #10466:
[FLINK-15110][metrics] Support variable exclusion
URL: https://github.com/apache/flink/pull/10466#discussion_r354906073
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -70,6 +71,7 @@
private final ScopeFormats scopeFormats;
private final char globalDelimiter;
private final List<Character> delimiters;
+ private final List<Set<String>> excludedVariables;
Review comment:
nit: `excludedVariables`, `delimiters` and `reporters` seem to have a
semantic relationship in the sense that the `ith` entry of these lists belong
together. One could think about making this relationship a bit more explicit by
introducing a common concept for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
