JingsongLi commented on a change in pull request #10399:
[FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType
in blink planner
URL: https://github.com/apache/flink/pull/10399#discussion_r354658627
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/converter/ExpressionConverter.java
##########
@@ -139,27 +139,19 @@ public RexNode visit(ValueLiteralExpression
valueLiteral) {
TimestampType timestampType = (TimestampType)
type;
LocalDateTime datetime =
extractValue(valueLiteral, LocalDateTime.class);
return
relBuilder.getRexBuilder().makeTimestampLiteral(
- new TimestampString(
- datetime.getYear(),
- datetime.getMonthValue(),
- datetime.getDayOfMonth(),
- datetime.getHour(),
- datetime.getMinute(),
-
datetime.getSecond()).withNanos(datetime.getNano()),
timestampType.getPrecision());
+ fromLocalDateTime(datetime),
timestampType.getPrecision());
case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
+ LocalZonedTimestampType lzTs =
(LocalZonedTimestampType) type;
TimeZone timeZone =
TimeZone.getTimeZone(this.relBuilder.getCluster()
.getPlanner()
.getContext()
.unwrap(FlinkContext.class)
.getTableConfig()
.getLocalTimeZone());
+ Instant instant = extractValue(valueLiteral,
java.time.Instant.class);
Review comment:
`java.time.Instant.class` -> `Instant.class`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
