JingsongLi commented on a change in pull request #10399:
[FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType
in blink planner
URL: https://github.com/apache/flink/pull/10399#discussion_r353576624
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/MethodCallGen.scala
##########
@@ -34,12 +34,12 @@ class MethodCallGen(method: Method) extends CallGenerator {
generateCallIfArgsNotNull(ctx, returnType, operands,
!method.getReturnType.isPrimitive) {
originalTerms => {
val terms = originalTerms.zip(method.getParameterTypes).map { case
(term, clazz) =>
- // convert the BinaryString parameter to String if the method
parameter accept String
- if (clazz == classOf[String]) {
- s"$term.toString()"
- } else {
- term
- }
+ // convert the BinaryString parameter to String if the method
parameter accept String
Review comment:
Revert?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
