GJL commented on a change in pull request #10309: [FLINK-14909][runtime] Let
tasks get scheduled in topological order when possible
URL: https://github.com/apache/flink/pull/10309#discussion_r351247117
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/LazyFromSourcesSchedulingStrategyTest.java
##########
@@ -377,4 +349,20 @@ private LazyFromSourcesSchedulingStrategy
startScheduling(TestingSchedulingTopol
schedulingStrategy.startScheduling();
return schedulingStrategy;
}
+
+ private void checkLatestScheduledVertices(final
List<TestingSchedulingExecutionVertex> expected) {
Review comment:
I think that by only looking at the method name it is difficult to
understand what `checkLatestScheduledVertices` does, i.e., is the parameter the
expected result or the actual result that will be checked. I would propose the
following name: `assertLatestScheduledVerticesAreEqualTo`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
