GJL commented on a change in pull request #10309: [FLINK-14909][runtime] Let
tasks get scheduled in topological order when possible
URL: https://github.com/apache/flink/pull/10309#discussion_r350771645
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java
##########
@@ -679,4 +708,19 @@ private void startScheduling(final SchedulerNG scheduler)
{
scheduler.setMainThreadExecutor(ComponentMainThreadExecutorServiceAdapter.forMainThread());
scheduler.startScheduling();
}
+
+ private static List<ExecutionVertexID>
getAllExecutionVertexIdsSorted(final JobGraph jobGraph) {
Review comment:
I'd rather create a copy of `deployedExecutionVertices`, sort it using your
comparator, and compare for list equality. The comparator is already unit
tested so it's result can be trusted. This way we would avoid re-implementing
logic from the comparator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
