guoweiM commented on a change in pull request #10152: [FLINK-14466][runtime]
Let YarnJobClusterEntrypoint use user code class loader
URL: https://github.com/apache/flink/pull/10152#discussion_r346669201
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
##########
@@ -126,7 +130,18 @@ public void testCopyFromLocalRecursiveWithoutScheme()
throws Exception {
final FileSystem targetFileSystem =
hdfsRootPath.getFileSystem(hadoopConfig);
final Path targetDir = targetFileSystem.getWorkingDirectory();
- testCopyFromLocalRecursive(targetFileSystem, targetDir,
tempFolder, false);
+ testCopyFromLocalRecursive(targetFileSystem, targetDir,
LOCAL_RESOURCE_DIRECTORY, tempFolder, false);
+ }
+
+ /**
+ * Verifies that a single file is properly copied.
+ */
+ @Test
+ public void testCopyAFileFromLocal() throws IOException,
URISyntaxException, InterruptedException {
Review comment:
If the `shipFile` is a file which is in a relative style for example "a.jar"
`shipPath.getParent()` would be null.
I could make the`shipFiles` to the absolute path to avoid this situation and
remove the new test.
I think this could work after some investigations. However, because this
branch is for a long time you could have a double-check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
