guoweiM commented on a change in pull request #10152: [FLINK-14466][runtime]
Let YarnJobClusterEntrypoint use user code class loader
URL: https://github.com/apache/flink/pull/10152#discussion_r347742496
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/FileJobGraphRetriever.java
##########
@@ -45,26 +51,39 @@
@Nonnull
private final String jobGraphFile;
- public FileJobGraphRetriever(@Nonnull String jobGraphFile) {
+ public FileJobGraphRetriever(@Nonnull String jobGraphFile, @Nullable
File usrLibDir) throws IOException {
+ super(usrLibDir);
this.jobGraphFile = jobGraphFile;
}
@Override
public JobGraph retrieveJobGraph(Configuration configuration) throws
FlinkException {
- File fp = new File(jobGraphFile);
+ final File fp = new File(jobGraphFile);
try (FileInputStream input = new FileInputStream(fp);
ObjectInputStream obInput = new
ObjectInputStream(input)) {
-
- return (JobGraph) obInput.readObject();
+ final JobGraph jobGraph = (JobGraph)
obInput.readObject();
+ addUserClassPathsToJobGraph(jobGraph);
+ return jobGraph;
} catch (FileNotFoundException e) {
throw new FlinkException("Could not find the JobGraph
file.", e);
} catch (ClassNotFoundException | IOException e) {
throw new FlinkException("Could not load the JobGraph
from file.", e);
}
}
- public static FileJobGraphRetriever createFrom(Configuration
configuration) {
- return new
FileJobGraphRetriever(configuration.getString(JOB_GRAPH_FILE_PATH));
+ private void addUserClassPathsToJobGraph(JobGraph jobGraph) {
+ final List<URL> classPaths = new ArrayList<>();
+
+ if (jobGraph.getClasspaths() != null) {
Review comment:
Yes. It cound. After that pr we could remove the checker. Thank you for
letting me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
