zhijiangW commented on a change in pull request #10029: [FLINK-14553][runtime]
Respect non-blocking output in StreamTask#processInput
URL: https://github.com/apache/flink/pull/10029#discussion_r343462393
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
##########
@@ -106,7 +107,7 @@
public OperatorChain(
StreamTask<OUT, OP> containingTask,
-
List<RecordWriter<SerializationDelegate<StreamRecord<OUT>>>> recordWriters) {
+
RecordWriterDelegate<SerializationDelegate<StreamRecord<OUT>>>
recordWriterDelegate) {
Review comment:
Yeah, the above way would make sense.
But we have to migrate `RecordWriterDelegate` and the implementations into
`flink-streaming-java` model because it would rely on the `StreamRecord` class.
Now I put them into the `flink-runtime` model together with `RecordWriter`
package. The existing `BatchTask` also uses `RecordWriter` instances, but i am
not sure whether it would also use `RecordWriterDelegate` future. So from this
point, it would no limitation to put it together with runtime model.
Another tiny consideration, the existing `RecordWriter` class also uses the
`IOReadableWritable` generics, so the respective delegate keeps the same
generics with the instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
