zhijiangW commented on a change in pull request #10029: [FLINK-14553][runtime] Respect non-blocking output in StreamTask#processInput URL: https://github.com/apache/flink/pull/10029#discussion_r343063167
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java ########## @@ -106,7 +107,7 @@ public OperatorChain( StreamTask<OUT, OP> containingTask, - List<RecordWriter<SerializationDelegate<StreamRecord<OUT>>>> recordWriters) { + RecordWriterDelegate<SerializationDelegate<StreamRecord<OUT>>> recordWriterDelegate) { Review comment: After double thinking, I have not found a proper way to make `SerializationDelegate` type inside `RecordWriterDelegate`. In other words, it would be more general as now to define generics `IOReadableWritable` in interface `RecordWriterDelegate`, to not limit the scope into `SerializationDelegate`. Or are there any good suggestions to do so? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services