tillrohrmann commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323225665
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java ########## @@ -942,10 +950,28 @@ public void attachJobGraph(List<JobVertex> topologiallySorted) throws JobExcepti new DefaultFailoverTopology(this)); } + public void setLegacyScheduling(final boolean legacyScheduling) { + this.legacyScheduling = legacyScheduling; + } + + public boolean isLegacyScheduling() { + return legacyScheduling; + } + + public void transitionToRunning() { + if (!transitionState(JobStatus.CREATED, JobStatus.RUNNING)) { + throw new IllegalStateException("Job may only be scheduled from state " + JobStatus.CREATED); + } + } + public void scheduleForExecution() throws JobException { assertRunningInJobMasterMainThread(); + if (isLegacyScheduling()) { Review comment: Why do we need this block? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services